From: David Miller <davem@davemloft.net>
To: davej@codemonkey.org.uk
Cc: mroos@linux.ee, xiyou.wangcong@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: netconsole warning in 4.19.0-rc7
Date: Fri, 19 Oct 2018 10:45:55 -0700 (PDT) [thread overview]
Message-ID: <20181019.104555.830780623382872282.davem@davemloft.net> (raw)
In-Reply-To: <20181019134704.ky2vqeij6m77qrpg@codemonkey.org.uk>
From: Dave Jones <davej@codemonkey.org.uk>
Date: Fri, 19 Oct 2018 09:47:04 -0400
> On Fri, Oct 19, 2018 at 12:51:38PM +0300, Meelis Roos wrote:
> > > > > I took another look at that error path. Turns out this is all we need I
> > > > > think..
> > > >
> > > > With this patch applied on top of 4.19-rc8, I stll get the warning:
> > > >
> > > > [ 13.722919] WARNING: CPU: 0 PID: 0 at kernel/softirq.c:168 __local_bh_enable_ip+0x2e/0x44
> > >
> > > It's going to be a couple days before I get chance to get back to this.
> > > Did the previous patch in this thread (without the _bh) fare any better?
> >
> > Tried it with rcu_read_unlock() instead, still the same.
>
> Ok, this is going to take more time than I have. DaveM, do you want
> to revert 6fe9487892b32cb1c8b8b0d552ed7222a527fe30, or do you want a
> patch doing the same ?
>
> That'll bring back the rcu warning, but fewer people were complaining
> about that than this new issue..
I'll revert.
Thanks Dave.
prev parent reply other threads:[~2018-10-19 17:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 12:06 netconsole warning in 4.19.0-rc7 Meelis Roos
2018-10-11 5:34 ` Cong Wang
2018-10-12 14:32 ` Dave Jones
2018-10-17 3:40 ` Dave Jones
2018-10-17 3:50 ` Dave Jones
2018-10-17 5:16 ` Cong Wang
2018-10-17 6:22 ` Meelis Roos
2018-10-18 14:59 ` Dave Jones
2018-10-19 9:51 ` Meelis Roos
2018-10-19 13:47 ` Dave Jones
2018-10-19 17:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019.104555.830780623382872282.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).