From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH net] qlcnic: fix a return in qlcnic_dcb_get_capability() Date: Fri, 19 Oct 2018 23:11:11 +0300 Message-ID: <20181019201111.xwetmozyy46xd3pg@kili.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Manish Chopra , Dept-GELinuxNICDev@cavium.com, "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Shahed Shaikh , Sucheta Chakraborty Return-path: Received: from userp2120.oracle.com ([156.151.31.85]:54400 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726156AbeJTETF (ORCPT ); Sat, 20 Oct 2018 00:19:05 -0400 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: These functions are supposed to return one on failure and zero on success. Returning a zero here could cause uninitialized variable bugs in several of the callers. For example: drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:1660 get_iscsi_dcb_priority() error: uninitialized symbol 'caps'. Fixes: 48365e485275 ("qlcnic: dcb: Add support for CEE Netlink interface.") Signed-off-by: Dan Carpenter --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c index 4b76c69fe86d..834208e55f7b 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c @@ -883,7 +883,7 @@ static u8 qlcnic_dcb_get_capability(struct net_device *netdev, int capid, struct qlcnic_adapter *adapter = netdev_priv(netdev); if (!test_bit(QLCNIC_DCB_STATE, &adapter->dcb->state)) - return 0; + return 1; switch (capid) { case DCB_CAP_ATTR_PG: -- 2.11.0