From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] Revert "neighbour: force neigh_invalidate when NUD_FAILED update is from admin" Date: Sat, 20 Oct 2018 22:26:57 -0700 (PDT) Message-ID: <20181020.222657.731816296109784832.davem@davemloft.net> References: <1540084171-12793-1-git-send-email-roopa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: roopa@cumulusnetworks.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:38944 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726881AbeJUNkC (ORCPT ); Sun, 21 Oct 2018 09:40:02 -0400 In-Reply-To: <1540084171-12793-1-git-send-email-roopa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Roopa Prabhu Date: Sat, 20 Oct 2018 18:09:31 -0700 > From: Roopa Prabhu > > This reverts commit 8e326289e3069dfc9fa9c209924668dd031ab8ef. > > This patch results in unnecessary netlink notification when one > tries to delete a neigh entry already in NUD_FAILED state. Found > this with a buggy app that tries to delete a NUD_FAILED entry > repeatedly. While the notification issue can be fixed with more > checks, adding more complexity here seems unnecessary. Also, > recent tests with other changes in the neighbour code have > shown that the INCOMPLETE and PROBE checks are good enough for > the original issue. > > Signed-off-by: Roopa Prabhu Applied, thanks.