From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Subject: Re: [PATCH iproute2 1/1] DEBUG: Fix make check when need build generate_nlmsg Date: Sat, 20 Oct 2018 21:15:16 +0200 Message-ID: <20181020191516.GA15790@x230> References: <20180925124956.10565-1-pvorel@suse.cz> Reply-To: Petr Vorel Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from mx2.suse.de ([195.135.220.15]:42690 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727423AbeJUD0o (ORCPT ); Sat, 20 Oct 2018 23:26:44 -0400 Content-Disposition: inline In-Reply-To: <20180925124956.10565-1-pvorel@suse.cz> Sender: netdev-owner@vger.kernel.org List-ID: Hi Stephen, > make check from top level Makefile defines several flags which break > building generate_nlmsg: > $ make check > make -C tools > gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wformat=2 -O2 -I../include -I../include/uapi -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -DNETNS_RUN_DIR=\"/var/run/netns\" -DNETNS_ETC_DIR=\"/etc/netns\" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DHAVE_SETNS -DHAVE_SELINUX -DHAVE_ELF -DHAVE_LIBMNL -I/usr/include/libmnl -DNEED_STRLCPY -DHAVE_LIBCAP ../lib/libutil.a ../lib/libnetlink.a -lselinux -lelf -lmnl -lcap -I../../include -include../../include/uapi/linux/netlink.h -o generate_nlmsg generate_nlmsg.c ../../lib/libnetlink.c -lmnl > gcc: error: ../lib/libutil.a: No such file or directory > gcc: error: ../lib/libnetlink.a: No such file or directory > make[2]: *** [Makefile:5: generate_nlmsg] Error 1 > make[1]: *** [Makefile:40: generate_nlmsg] Error 2 > To fix it reset CFLAGS in sub Makefile and remove LDLIBS entirely (as > required -lmnl flag was specified in 5dc2204c ("testsuite: add libmnl"). > Fixes: 8804a8c0 ("Makefile: Add check target") > Signed-off-by: Petr Vorel > --- > Hi Stephen, > I'm sorry for this regression. > Kind regards, > Petr > --- > testsuite/tools/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > diff --git a/testsuite/tools/Makefile b/testsuite/tools/Makefile > index 7d53d226..e1d9bfef 100644 > --- a/testsuite/tools/Makefile > +++ b/testsuite/tools/Makefile > @@ -1,8 +1,9 @@ > # SPDX-License-Identifier: GPL-2.0 > +CFLAGS= > include ../../config.mk > generate_nlmsg: generate_nlmsg.c ../../lib/libnetlink.c > - $(CC) $(CPPFLAGS) $(CFLAGS) $(LDLIBS) $(EXTRA_CFLAGS) -I../../include -include../../include/uapi/linux/netlink.h -o $@ $^ -lmnl > + $(CC) $(CPPFLAGS) $(CFLAGS) $(EXTRA_CFLAGS) -I../../include -include../../include/uapi/linux/netlink.h -o $@ $^ -lmnl > clean: > rm -f generate_nlmsg ping, please. Patch is in state "accepted in patchwork [1], but not merged. Subject should be "testsuite: Fix make check when need build generate_nlmsg". Kind regards, Petr [1] https://patchwork.ozlabs.org/patch/974391/