From: Daniel Borkmann <daniel@iogearbox.net>
To: alexei.starovoitov@gmail.com
Cc: netdev@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>
Subject: [PATCH bpf-next 4/6] bpf, verifier: remove unneeded flow key in check_helper_mem_access
Date: Sun, 21 Oct 2018 02:09:26 +0200 [thread overview]
Message-ID: <20181021000928.15705-5-daniel@iogearbox.net> (raw)
In-Reply-To: <20181021000928.15705-1-daniel@iogearbox.net>
They PTR_TO_FLOW_KEYS is not used today to be passed into a helper
as memory, so it can be removed from check_helper_mem_access().
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
---
kernel/bpf/verifier.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 0450ffc..4f727c9 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -2077,8 +2077,6 @@ static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
case PTR_TO_PACKET_META:
return check_packet_access(env, regno, reg->off, access_size,
zero_size_allowed);
- case PTR_TO_FLOW_KEYS:
- return check_flow_keys_access(env, reg->off, access_size);
case PTR_TO_MAP_VALUE:
return check_map_access(env, regno, reg->off, access_size,
zero_size_allowed);
--
2.9.5
next prev parent reply other threads:[~2018-10-21 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 0:09 [PATCH bpf-next 0/6] Misc improvements and few minor fixes Daniel Borkmann
2018-10-21 0:09 ` [PATCH bpf-next 1/6] ulp: remove uid and user_visible members Daniel Borkmann
2018-10-21 0:09 ` [PATCH bpf-next 2/6] bpf, verifier: fix register type dump in xadd and st Daniel Borkmann
2018-10-21 0:09 ` [PATCH bpf-next 3/6] bpf, verifier: reject xadd on flow key memory Daniel Borkmann
2018-10-21 0:09 ` Daniel Borkmann [this message]
2018-10-21 0:09 ` [PATCH bpf-next 5/6] bpf, verifier: avoid retpoline for map push/pop/peek operation Daniel Borkmann
2018-10-21 0:09 ` [PATCH bpf-next 6/6] bpf, libbpf: simplify and cleanup perf ring buffer walk Daniel Borkmann
2018-10-21 6:18 ` [PATCH bpf-next 0/6] Misc improvements and few minor fixes Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181021000928.15705-5-daniel@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).