From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] qlcnic: fix a return in qlcnic_dcb_get_capability()
Date: Mon, 22 Oct 2018 19:34:45 -0700 (PDT)
Message-ID: <20181022.193445.1141993426806484413.davem@davemloft.net>
References: <20181019201111.xwetmozyy46xd3pg@kili.mountain>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: Shahed.Shaikh@cavium.com, sucheta.chakraborty@qlogic.com,
        manish.chopra@cavium.com, Dept-GELinuxNICDev@cavium.com,
        netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
To: dan.carpenter@oracle.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:39882 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725768AbeJWK4A (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 23 Oct 2018 06:56:00 -0400
In-Reply-To: <20181019201111.xwetmozyy46xd3pg@kili.mountain>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 19 Oct 2018 23:11:11 +0300

> These functions are supposed to return one on failure and zero on
> success.  Returning a zero here could cause uninitialized variable
> bugs in several of the callers.  For example:
> 
>     drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:1660 get_iscsi_dcb_priority()
>     error: uninitialized symbol 'caps'.
> 
> Fixes: 48365e485275 ("qlcnic: dcb: Add support for CEE Netlink interface.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.