From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/2] umh: Add command line to user mode helpers Date: Mon, 22 Oct 2018 19:37:46 -0700 (PDT) Message-ID: <20181022.193746.688608612910779105.davem@davemloft.net> References: <20181020173957.31239-1-jjk@jjacky.com> <20181020173957.31239-2-jjk@jjacky.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, alexei.starovoitov@gmail.com, daniel@iogearbox.net, mcgrof@kernel.org, linux-kernel@vger.kernel.org To: jjk@jjacky.com Return-path: In-Reply-To: <20181020173957.31239-2-jjk@jjacky.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Olivier Brunel Date: Sat, 20 Oct 2018 19:39:56 +0200 > User mode helpers were spawned without a command line, and because > an empty command line is used by many tools to identify processes as > kernel threads, this could cause some issues. > > Notably during killing spree on shutdown, since such helper would then > be skipped (i.e. not killed) which would result in the process remaining > alive, and thus preventing unmouting of the rootfs (as experienced with > the bpfilter umh). > > Fixes: 449325b52b7a ("umh: introduce fork_usermode_blob() helper") > Signed-off-by: Olivier Brunel Applied.