From: Stephen Hemminger <stephen@networkplumber.org>
To: Petr Vorel <pvorel@suse.cz>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 1/1] DEBUG: Fix make check when need build generate_nlmsg
Date: Mon, 22 Oct 2018 09:51:06 -0700 [thread overview]
Message-ID: <20181022095106.5fb7a690@xeon-e3> (raw)
In-Reply-To: <20180925124956.10565-1-pvorel@suse.cz>
On Tue, 25 Sep 2018 14:49:56 +0200
Petr Vorel <pvorel@suse.cz> wrote:
> make check from top level Makefile defines several flags which break
> building generate_nlmsg:
>
> $ make check
> make -C tools
> gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wformat=2 -O2 -I../include -I../include/uapi -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -DNETNS_RUN_DIR=\"/var/run/netns\" -DNETNS_ETC_DIR=\"/etc/netns\" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DHAVE_SETNS -DHAVE_SELINUX -DHAVE_ELF -DHAVE_LIBMNL -I/usr/include/libmnl -DNEED_STRLCPY -DHAVE_LIBCAP ../lib/libutil.a ../lib/libnetlink.a -lselinux -lelf -lmnl -lcap -I../../include -include../../include/uapi/linux/netlink.h -o generate_nlmsg generate_nlmsg.c ../../lib/libnetlink.c -lmnl
> gcc: error: ../lib/libutil.a: No such file or directory
> gcc: error: ../lib/libnetlink.a: No such file or directory
> make[2]: *** [Makefile:5: generate_nlmsg] Error 1
> make[1]: *** [Makefile:40: generate_nlmsg] Error 2
>
> To fix it reset CFLAGS in sub Makefile and remove LDLIBS entirely (as
> required -lmnl flag was specified in 5dc2204c ("testsuite: add libmnl").
>
> Fixes: 8804a8c0 ("Makefile: Add check target")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi Stephen,
>
> I'm sorry for this regression.
>
> Kind regards,
> Petr
Applied, it seem to have gotten lost somewhere between my laptop and the repo.
next prev parent reply other threads:[~2018-10-23 1:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 12:49 [PATCH iproute2 1/1] DEBUG: Fix make check when need build generate_nlmsg Petr Vorel
2018-10-20 19:15 ` Petr Vorel
2018-10-22 16:51 ` Stephen Hemminger [this message]
2018-10-22 17:03 ` Petr Vorel
2018-10-22 17:09 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022095106.5fb7a690@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).