From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [iproute2 PATCH] bridge: fix vlan show stats formatting Date: Mon, 22 Oct 2018 10:00:01 -0700 Message-ID: <20181022100001.3413fe1c@xeon-e3> References: <09b37bb3d091567c1f8958994e69e1221a61c0dc.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org To: Tobias Jungel Return-path: Received: from mail-pg1-f194.google.com ([209.85.215.194]:39901 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727218AbeJWBTV (ORCPT ); Mon, 22 Oct 2018 21:19:21 -0400 Received: by mail-pg1-f194.google.com with SMTP id r9-v6so19307995pgv.6 for ; Mon, 22 Oct 2018 10:00:03 -0700 (PDT) In-Reply-To: <09b37bb3d091567c1f8958994e69e1221a61c0dc.camel@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 20 Oct 2018 15:42:33 +0200 Tobias Jungel wrote: > The output of -statistics vlan show was broken previous change for json > output. This aligns the format to vlan show. >=20 > Signed-off-by: Tobias Jungel This patch causes new warning: CC vlan.o vlan.c: In function =E2=80=98print_vlan_stats_attr=E2=80=99: vlan.c:492:2: warning: =E2=80=98ifname=E2=80=99 may be used uninitialized i= n this function [-Wmaybe-uninitialized] print_color_string(PRINT_FP, COLOR_IFNAME, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NULL, "%-16s", ifname); ~~~~~~~~~~~~~~~~~~~~~~ Reverting the patch, please fix and resubmit.