From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [iproute PATCH] ip-route: Fix for memleak in error path Date: Mon, 22 Oct 2018 10:06:45 -0700 Message-ID: <20181022100645.478bdaac@xeon-e3> References: <20181018123031.19854-1-phil@nwl.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Phil Sutter Return-path: Received: from mail-pg1-f170.google.com ([209.85.215.170]:43754 "EHLO mail-pg1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727218AbeJWB0H (ORCPT ); Mon, 22 Oct 2018 21:26:07 -0400 Received: by mail-pg1-f170.google.com with SMTP id d8-v6so8091343pgv.10 for ; Mon, 22 Oct 2018 10:06:48 -0700 (PDT) In-Reply-To: <20181018123031.19854-1-phil@nwl.cc> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 18 Oct 2018 14:30:31 +0200 Phil Sutter wrote: > If call to rta_addattr_l() failed, parse_encap_seg6() would leak memory. > Fix this by making sure calls to free() are not skipped. > > Fixes: bd59e5b1517b0 ("ip-route: Fix segfault with many nexthops") > Signed-off-by: Phil Sutter Applied, thanks.