From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 2/4] net: phy-c45: Populate autoneg_done callback Date: Mon, 22 Oct 2018 14:21:21 +0200 Message-ID: <20181022122121.GA24112@lunn.ch> References: <65a0791a760dc488f62445343e041baf4a2db17e.1540204183.git.joabreu@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Florian Fainelli , "David S. Miller" , Joao Pinto To: Jose Abreu Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:40124 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728052AbeJVUjq (ORCPT ); Mon, 22 Oct 2018 16:39:46 -0400 Content-Disposition: inline In-Reply-To: <65a0791a760dc488f62445343e041baf4a2db17e.1540204183.git.joabreu@synopsys.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Oct 22, 2018 at 11:32:47AM +0100, Jose Abreu wrote: > We already have this callback implemented. Use it in driver structure. > > Signed-off-by: Jose Abreu > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: "David S. Miller" > Cc: Joao Pinto > --- > drivers/net/phy/phy-c45.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c > index e1225545362d..c0135217b81f 100644 > --- a/drivers/net/phy/phy-c45.c > +++ b/drivers/net/phy/phy-c45.c > @@ -330,6 +330,7 @@ struct phy_driver genphy_10g_driver = { > .soft_reset = gen10g_no_soft_reset, > .config_init = gen10g_config_init, > .features = 0, > + .aneg_done = genphy_c45_aneg_done, > .config_aneg = gen10g_config_aneg, > .read_status = gen10g_read_status, > .suspend = gen10g_suspend, We should probably do something about the naming. I need to look at the history to understand why we have gen10g_ and genphy_c45_. Andrew