From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 1/1] qed: Fix static checker warning Date: Tue, 23 Oct 2018 11:05:56 -0700 (PDT) Message-ID: <20181023.110556.1689477118069474659.davem@davemloft.net> References: <20181023150424.6046-1-rahul.verma@cavium.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Ariel.Elior@cavium.com, Dept-EngEverestLinuxL2@cavium.com To: rahul.verma@cavium.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:50970 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbeJXCaX (ORCPT ); Tue, 23 Oct 2018 22:30:23 -0400 In-Reply-To: <20181023150424.6046-1-rahul.verma@cavium.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Rahul Verma Date: Tue, 23 Oct 2018 08:04:24 -0700 > From: Rahul Verma > > Static Checker Warnings: > drivers/net/ethernet/qlogic/qed/qed_main.c:1510 qed_fill_link_capability() > error: uninitialized symbol 'tcvr_state'. > drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask() > error: uninitialized symbol 'transceiver_state'. > drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask() > error: uninitialized symbol 'transceiver_type'. > > Symbols tcvr_state, transceiver_state and transceiver_type > are initialized with respective default state. > > Fixes: c56a8be7e7aa (qed: Add supported link and advertise link to display in ethtool.) Referenced commits shall be of the form: SHA1_ID ("Commit header text.") Meaning that text must be contained inside of parenthesis and also double quotes. Please do not forget the double quotes in the future. > Reported-by: Dan Carpenter > Signed-off-by: Rahul Verma Fixed, and applied. Thanks.