From mboxrd@z Thu Jan 1 00:00:00 1970 From: masahisa.kojima@linaro.org Subject: [PATCH net v2 3/3] net: socionext: Reset tx queue in ndo_stop Date: Tue, 23 Oct 2018 20:24:28 +0900 Message-ID: <20181023112428.6785-4-masahisa.kojima@linaro.org> References: <20181023112428.6785-1-masahisa.kojima@linaro.org> Cc: ilias.apalodimas@linaro.org, jaswinder.singh@linaro.org, ard.biesheuvel@linaro.org, osaki.yoshitoyo@socionext.com, Masahisa Kojima To: netdev@vger.kernel.org Return-path: Received: from mail-yw1-f65.google.com ([209.85.161.65]:40502 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727873AbeJWTtn (ORCPT ); Tue, 23 Oct 2018 15:49:43 -0400 Received: by mail-yw1-f65.google.com with SMTP id l79-v6so371790ywc.7 for ; Tue, 23 Oct 2018 04:26:39 -0700 (PDT) In-Reply-To: <20181023112428.6785-1-masahisa.kojima@linaro.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Masahisa Kojima We observed that packets and bytes count are not reset when user performs interface down. Eventually, tx queue is exhausted and packets will not be sent out. To avoid this problem, resets tx queue in ndo_stop. Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver") Signed-off-by: Masahisa Kojima Signed-off-by: Yoshitoyo Osaki --- changes in v2: - update commit comment drivers/net/ethernet/socionext/netsec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c index 5c295cc0b8f8..d4da7e017207 100644 --- a/drivers/net/ethernet/socionext/netsec.c +++ b/drivers/net/ethernet/socionext/netsec.c @@ -952,6 +952,9 @@ static void netsec_uninit_pkt_dring(struct netsec_priv *priv, int id) dring->head = 0; dring->tail = 0; dring->pkt_cnt = 0; + + if (id == NETSEC_RING_TX) + netdev_reset_queue(priv->ndev); } static void netsec_free_dring(struct netsec_priv *priv, int id) -- 2.14.2