From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH net-next] octeontx2-af: Copy the right amount of memory Date: Wed, 24 Oct 2018 11:32:21 +0300 Message-ID: <20181024083221.humvwh2pefovptcd@kili.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linu Cherian , Geetha sowjanya , Jerin Jacob , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Sunil Goutham Return-path: Received: from aserp2120.oracle.com ([141.146.126.78]:46186 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbeJXQ77 (ORCPT ); Wed, 24 Oct 2018 12:59:59 -0400 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: This is a copy and paste bug where we copied the sizeof() from the chunk before. We're copying more data than intended but the destination is a union so it doesn't cause memory corruption. Fixes: ffb0abd7e9cb ("octeontx2-af: NIX AQ instruction enqueue support") Signed-off-by: Dan Carpenter --- drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c index 8890c95831ca..a4eac3b9ee72 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c @@ -573,7 +573,7 @@ static int rvu_nix_aq_enq_inst(struct rvu *rvu, struct nix_aq_enq_req *req, sizeof(struct nix_cq_ctx_s)); else if (req->ctype == NIX_AQ_CTYPE_RSS) memcpy(&rsp->rss, ctx, - sizeof(struct nix_cq_ctx_s)); + sizeof(struct nix_rsse_s)); else if (req->ctype == NIX_AQ_CTYPE_MCE) memcpy(&rsp->mce, ctx, sizeof(struct nix_rx_mce_s)); -- 2.11.0