From: Stephen Hemminger <stephen@networkplumber.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: David Miller <davem@davemloft.net>,
nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH] r8169: Add new device ID support
Date: Wed, 24 Oct 2018 08:47:10 -0700 [thread overview]
Message-ID: <20181024084710.05a5abc4@xeon-e3> (raw)
In-Reply-To: <db4ae0f0-97e4-d2c1-9ac9-e689e3d80447@rock-chips.com>
On Wed, 24 Oct 2018 14:29:34 +0800
Shawn Lin <shawn.lin@rock-chips.com> wrote:
> On 2018/10/24 13:54, David Miller wrote:
> > From: Shawn Lin <shawn.lin@rock-chips.com>
> > Date: Wed, 24 Oct 2018 13:48:55 +0800
> >
> >> Hi David,
> >>
> >> On 2018/10/24 10:19, David Miller wrote:
> >>> From: Shawn Lin <shawn.lin@rock-chips.com>
> >>> Date: Wed, 24 Oct 2018 09:46:47 +0800
> >>>
> >>>> It's found my r8169 ethernet card at hand has a device ID
> >>>> of 0x0000 which wasn't on the list of rtl8169_pci_tbl. Add
> >>>> a new entry to make it work:
> >>> ...
> >>>> 01:00.0 Class 0200: 10ec:0000
> >>> I don't know about this.
> >>> A value of zero could mean the device is mis-responding to
> >>> PCI config space requests or something like that.
> >>
> >> It was working fine on my retired Windows XP home PC with same devcice
> >> ID listed, so I guess r8169 driver for windows system knows 0x0000 is
> >> also valid.
> >
> > It is also possible the device comes up in a different state.
> >
> > Under windows does it show with that device ID of zero?
>
> yup. More precisely, I checked how BIOS enumerate it by PCIe analyzer
> and see it does report 0x0000 as device ID.
>
> >
> >
> >
>
Look at device manager properties of the device in Windows?
next prev parent reply other threads:[~2018-10-25 0:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1540345607-110155-1-git-send-email-shawn.lin@rock-chips.com>
2018-10-24 2:19 ` [PATCH] r8169: Add new device ID support David Miller
2018-10-24 5:48 ` Shawn Lin
2018-10-24 5:54 ` David Miller
2018-10-24 6:29 ` Shawn Lin
2018-10-24 15:47 ` Stephen Hemminger [this message]
2018-10-24 21:22 ` David Miller
2018-10-24 21:44 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024084710.05a5abc4@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).