From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] r8169: Add new device ID support
Date: Wed, 24 Oct 2018 08:47:10 -0700
Message-ID: <20181024084710.05a5abc4@xeon-e3>
References: <1540345607-110155-1-git-send-email-shawn.lin@rock-chips.com>
        <20181023.191914.36695990470437174.davem@davemloft.net>
        <37d7eebe-5abc-2fe2-adae-562e424f8108@rock-chips.com>
        <20181023.225442.1195260610454764659.davem@davemloft.net>
        <db4ae0f0-97e4-d2c1-9ac9-e689e3d80447@rock-chips.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>, nic_swsd@realtek.com,
        netdev@vger.kernel.org
To: Shawn Lin <shawn.lin@rock-chips.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f194.google.com ([209.85.210.194]:46929 "EHLO
        mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726449AbeJYAP4 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 24 Oct 2018 20:15:56 -0400
Received: by mail-pf1-f194.google.com with SMTP id r64-v6so2605166pfb.13
        for <netdev@vger.kernel.org>; Wed, 24 Oct 2018 08:47:20 -0700 (PDT)
In-Reply-To: <db4ae0f0-97e4-d2c1-9ac9-e689e3d80447@rock-chips.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 24 Oct 2018 14:29:34 +0800
Shawn Lin <shawn.lin@rock-chips.com> wrote:

> On 2018/10/24 13:54, David Miller wrote:
> > From: Shawn Lin <shawn.lin@rock-chips.com>
> > Date: Wed, 24 Oct 2018 13:48:55 +0800
> >   
> >> Hi David,
> >>
> >> On 2018/10/24 10:19, David Miller wrote:  
> >>> From: Shawn Lin <shawn.lin@rock-chips.com>
> >>> Date: Wed, 24 Oct 2018 09:46:47 +0800
> >>>  
> >>>> It's found my r8169 ethernet card at hand has a device ID
> >>>> of 0x0000 which wasn't on the list of rtl8169_pci_tbl. Add
> >>>> a new entry to make it work:  
> >>>    ...  
> >>>> 01:00.0 Class 0200: 10ec:0000  
> >>> I don't know about this.
> >>> A value of zero could mean the device is mis-responding to
> >>> PCI config space requests or something like that.  
> >>
> >> It was working fine on my retired Windows XP home PC with same devcice
> >> ID listed, so I guess r8169 driver for windows system knows 0x0000 is
> >> also valid.  
> > 
> > It is also possible the device comes up in a different state.
> > 
> > Under windows does it show with that device ID of zero?  
> 
> yup. More precisely, I checked how BIOS enumerate it by PCIe analyzer
> and see it does report 0x0000 as device ID.
> 
> > 
> > 
> >   
> 

Look at device manager properties of the device in Windows?