From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 3/4] net: phy-c45: Implement
 reset/suspend/resume callbacks
Date: Wed, 24 Oct 2018 14:03:53 +0200
Message-ID: <20181024120353.GA12447@lunn.ch>
References: <b65cd0978587224eb1496ad60d224394525b8ba6.1540204183.git.joabreu@synopsys.com>
 <20181022122839.GB24112@lunn.ch>
 <8114f345-0efb-9a64-b867-2cfe2fba09ab@synopsys.com>
 <20181022154851.GA1492@n2100.armlinux.org.uk>
 <f8cd48a0-2cf5-5718-a6a6-1e9824834720@gmail.com>
 <943a6194-001a-d6a0-84ba-b93b728ce64b@synopsys.com>
 <20181023102023.GM30658@n2100.armlinux.org.uk>
 <d7abcce6-e935-8897-0307-8c5a8afd0990@synopsys.com>
 <20181023105828.GN30658@n2100.armlinux.org.uk>
 <5e65254c-04dc-6dba-eb1c-10bafadf95c5@synopsys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
        Florian Fainelli <f.fainelli@gmail.com>,
        netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Joao Pinto <joao.pinto@synopsys.com>
To: Jose Abreu <jose.abreu@synopsys.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:41871 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726812AbeJXUbv (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 24 Oct 2018 16:31:51 -0400
Content-Disposition: inline
In-Reply-To: <5e65254c-04dc-6dba-eb1c-10bafadf95c5@synopsys.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> Since 719655a14971 ("net: phy: Replace phy driver features u32
> with link_mode bitmap"), phy_probe() calls
> ethtool_convert_link_mode_to_legacy_u32() with phydrv->features
> as argument. Since features are NULL, we will get NULL pointer
> dereference.

Hi Jose

Thanks for pointing that out. I will fix it ASAP.

       Andrew