From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next] net/ipv6: Block IPv6 addrconf on team ports Date: Thu, 25 Oct 2018 23:10:09 +0200 Message-ID: <20181025211008.GA2229@nanopsycho.orion> References: <20181025210227.25544-1-3chas3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, netdev@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org To: Chas Williams <3chas3@gmail.com> Return-path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:45780 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbeJZFuX (ORCPT ); Fri, 26 Oct 2018 01:50:23 -0400 Received: by mail-wr1-f68.google.com with SMTP id n5-v6so6973921wrw.12 for ; Thu, 25 Oct 2018 14:16:04 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181025210227.25544-1-3chas3@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Oct 25, 2018 at 11:02:27PM CEST, 3chas3@gmail.com wrote: >netif_is_lag_port should be used to identify link aggregation ports. >For this to work, we need to reorganize the bonding and team drivers >so that the necessary flags are set before dev_open is called. > >commit 31e77c93e432 ("sched/fair: Update blocked load when newly idle") >made this decision originally based on the IFF_SLAVE flag which isn't >used by the team driver. Note, we do need to retain the IFF_SLAVE >check for the eql driver. > >Signed-off-by: Chas Williams <3chas3@gmail.com> >--- > drivers/net/bonding/bond_main.c | 4 ++-- > drivers/net/team/team.c | 7 +++++-- > net/ipv6/addrconf.c | 2 +- Subject talks about "team" yet you modify bond and team. Confusing..