From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: CAKE and r8169 cause panic on upload in v4.19
Date: Sat, 27 Oct 2018 21:44:26 -0700 (PDT)
Message-ID: <20181027.214426.537959459795607171.davem@davemloft.net>
References: <fbd7f0b8-10c8-be17-fce6-327a95d8ea2e@gmail.com>
        <CAA93jw7xoaokrN4oGAyqh6JHAn8nJpUpp_wj-iy+GWNoV-ipNA@mail.gmail.com>
        <b80e6819da8ea74f18b6ec0aaf9128fa@natalenko.name>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: dave.taht@gmail.com, hkallweit1@gmail.com, toke@toke.dk,
        jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
To: oleksandr@natalenko.name
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <b80e6819da8ea74f18b6ec0aaf9128fa@natalenko.name>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: Oleksandr Natalenko <oleksandr@natalenko.name>
Date: Fri, 26 Oct 2018 22:54:12 +0200

> Next, I've seen GRO bits in the call trace and decided to disable GRO
> on this NIC. So far, I cannot trigger a panic with GRO disabled even
> after 20 rounds of speedtest.
> 
> So, must be some generic thing indeed.

Yeah something is out-of-whack with GRO.

Does this fix it?

diff --git a/net/core/dev.c b/net/core/dev.c
index 022ad73d6253..77d43ae2a7bb 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5457,7 +5457,7 @@ static void gro_flush_oldest(struct list_head *head)
 	/* Do not adjust napi->gro_hash[].count, caller is adding a new
 	 * SKB to the chain.
 	 */
-	list_del(&oldest->list);
+	skb_list_del_init(oldest);
 	napi_gro_complete(oldest);
 }