Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: tgraf@suug.ch, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
	netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH net] net: sched: gred: pass the right attribute to gred_change_table_def()
Date: Sun, 28 Oct 2018 19:24:01 -0700 (PDT)	[thread overview]
Message-ID: <20181028.192401.1794880879917119232.davem@davemloft.net> (raw)
In-Reply-To: <20181026225106.5510-1-jakub.kicinski@netronome.com>

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Fri, 26 Oct 2018 15:51:06 -0700

> gred_change_table_def() takes a pointer to TCA_GRED_DPS attribute,
> and expects it will be able to interpret its contents as
> struct tc_gred_sopt.  Pass the correct gred attribute, instead of
> TCA_OPTIONS.
> 
> This bug meant the table definition could never be changed after
> Qdisc was initialized (unless whatever TCA_OPTIONS contained both
> passed netlink validation and was a valid struct tc_gred_sopt...).
 ...
> Fixes: f62d6b936df5 ("[PKT_SCHED]: GRED: Use central VQ change procedure")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>

Quite an ancient bug :-)

Applied and queued up for -stable, thanks!

      reply	other threads:[~2018-10-29 11:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26 22:51 [PATCH net] net: sched: gred: pass the right attribute to gred_change_table_def() Jakub Kicinski
2018-10-29  2:24 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181028.192401.1794880879917119232.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    --cc=tgraf@suug.ch \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox