Re: [iproute2 PATCH] bridge: fix vlan show stats formatting

Stephen Hemminger
2018-10-23T01:19:21Z

On Sat, 20 Oct 2018 15:42:33 +0200
Tobias Jungel <tobias.jungel@gmail.com> wrote:

> The output of -statistics vlan show was broken previous change for json
> output. This aligns the format to vlan show.
>
> Signed-off-by: Tobias Jungel <tobias.jungel@gmail.com>

This patch causes new warning:
CC vlan.o
vlan.c: In function ‘print_vlan_stats_attr’:
vlan.c:492:2: warning: ‘ifname’ may be used uninitialized in this function [-Wmaybe-uninitialized]
print_color_string(PRINT_FP, COLOR_IFNAME,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NULL, "%-16s", ifname);
~~~~~~~~~~~~~~~~~~~~~~

Reverting the patch, please fix and resubmit.