From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miroslav Lichvar Subject: Re: [Intel-wired-lan] [RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl Date: Mon, 29 Oct 2018 13:52:09 +0100 Message-ID: <20181029125209.GC31668@localhost> References: <20181026162742.631-1-mlichvar@redhat.com> <20181026162742.631-2-mlichvar@redhat.com> <87in1o73qo.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Richard Cochran , intel-wired-lan@lists.osuosl.org To: Vinicius Costa Gomes Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26021 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729314AbeJ2Vkp (ORCPT ); Mon, 29 Oct 2018 17:40:45 -0400 Content-Disposition: inline In-Reply-To: <87in1o73qo.fsf@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Oct 26, 2018 at 03:16:47PM -0700, Vinicius Costa Gomes wrote: > > + case PTP_SYS_OFFSET_EXTENDED: > > + if (!ptp->info->gettimex64) { > > + err = -EOPNOTSUPP; > > + break; > > + } > > + sysoff_extended = memdup_user((void __user *)arg, > > + sizeof(*sysoff_extended)); > > Looks like you forgot to free 'sysoff_extended', no? Oh, I did. Thanks for catching that. I'll fix it in the next version. -- Miroslav Lichvar