From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH iproute2-next 3/3] rdma: Add an option to rename IB
 device interface
Date: Mon, 29 Oct 2018 19:34:46 +0200
Message-ID: <20181029173446.GI3974@mtr-leonro.mtl.com>
References: <20181018115120.17893-1-leon@kernel.org>
 <20181018115120.17893-4-leon@kernel.org>
 <c1896e09-2081-858a-70fd-6fe9c998efa0@gmail.com>
 <20181029103046.GQ3974@mtr-leonro.mtl.com>
 <b7151495-d8ab-209b-a86e-575fc2f4ed53@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="Bu8it7iiRSEf40bY"
Cc: netdev <netdev@vger.kernel.org>,
        RDMA mailing list <linux-rdma@vger.kernel.org>,
        Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsahern@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:36968 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726205AbeJ3CY0 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 29 Oct 2018 22:24:26 -0400
Content-Disposition: inline
In-Reply-To: <b7151495-d8ab-209b-a86e-575fc2f4ed53@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


--Bu8it7iiRSEf40bY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Oct 29, 2018 at 11:07:06AM -0600, David Ahern wrote:
> On 10/29/18 4:30 AM, Leon Romanovsky wrote:
> >
> > Sorry for being slow in response, I was on vacation.
> > ----------
> >
> > This print is intended to warn about missing "new name" and it is not
> > checked by rd_exec_require_dev()
> >
> > To emphasize it:
> >
> > diff --git a/rdma/dev.c b/rdma/dev.c
> > index 760b7fb3..468ae686 100644
> > --- a/rdma/dev.c
> > +++ b/rdma/dev.c
> > @@ -246,6 +246,7 @@ static int dev_set_name(struct rd *rd)
> >         uint32_t seq;
> >
> > 	if (rd_no_arg(rd)) {
> > +               pr_err("hello world\n");
> >                 pr_err("Please provide device new  name.\n");
> > 		return -EINVAL;
> > 	}
> >
> > Produces the following output:
> > [leonro@server iproute2]$ ./rdma/rdma dev set mlx5_0 name
> > hello world
> > Please provide device new name.
> >
> > So how will we progress from here? Should I respin?
>
> ok, thanks for the explanation.
>
> Steve mentioned an update to the man page is needed as well. Please do
> that in the respin.

No problem, will do, thanks

>
> Thanks,

--Bu8it7iiRSEf40bY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIcBAEBAgAGBQJb10S2AAoJEORje4g2clinVnkP/jK5Lv5V19NnQlgljNeE6dI2
qqnfPmQZBuLlLodthAjKZHyLa2le3AYXAOsj0sRcUb+YgeCj9GLtKTNJdY66CIYt
0Vy9LA50GqzX5kXZraja0NpD5qYvBSsUE+/fYj0/aPbtjy1Wt0VxkMjOcevIuHjb
9bXhqO0zENJLVyVSmoGmjQHGGR1vUh1jgaUAiWGVd2rMYvYfPHpt74N6FZfp4dZD
cRisnW51HlQ5jaZ/bP1PIyHF9lVdiUKQx3XV+kKlzvBtqRe+yIlXGZ1lNRFkrMKZ
Xv7JPSdJ1fGyZrdVZvzzN2JKkq27xSceCFbHnjfoj/HnOOGGPj39eam9OSARCrKp
O2kU7LLqe9NjnCvFdh1lVexr51AFKXElZ7X1aaGTFB7ycvEI9/cDEc/pH5iUvtnX
FKGNjL0xPqqyqHuZZHBa6gicT2zelgeyRgHHt2kQbbcBKfCrqT4VnKvPNAThzJq5
R8WF+UBm0PKQDY7YiX/BpcHr9S2KwvGbUTS/e36XdzUbDaMCuUQ20Lxiu1vLTftJ
BgJUnh4852TnVPOzqTbEm70rkCVluO7X83gvf1ssZWoP9lAP0PE4uHuwHuwGKIX8
NGyv9t54M8gibLGNodqViGwco5o5FGaJQjyg8LZQVjg9ZJ+R37LJj2pDd7JsGs4p
+nwTbKKymFJ13inQ0HGO
=FvKS
-----END PGP SIGNATURE-----

--Bu8it7iiRSEf40bY--