From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [BUG] MVPP2 driver exploding in presence of a tap interface Date: Tue, 30 Oct 2018 16:10:07 +0100 Message-ID: <20181030161007.360d5a53@windsurf> References: <6355174d-4ab6-595d-17db-311bce607aef@arm.com> <20181030105015.GB3407@kwain> <7bd72963-1e7c-5175-ba88-fc020d786f0c@arm.com> <20181030140056.2fc69efc@windsurf> <6bf82e04-5463-aa7d-bbac-f09519ff9815@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Marcin Wojtas , Antoine Tenart , Maxime Chevallier , linux-arm-kernel@lists.infradead.org, netdev , Grzegorz Jaszczyk , Tomasz Nowicki To: Marc Zyngier Return-path: Received: from mail.bootlin.com ([62.4.15.54]:59518 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726903AbeJaAEB (ORCPT ); Tue, 30 Oct 2018 20:04:01 -0400 In-Reply-To: <6bf82e04-5463-aa7d-bbac-f09519ff9815@arm.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello, On Tue, 30 Oct 2018 14:55:01 +0000, Marc Zyngier wrote: > > I.e, isn't the firmware fix papering over a bug that should be fixed in > > Linux mvpp2 driver anyway ? > > Absolutely. Leaving this unpatched in the kernel, with a 100% chance of > memory corruption is just mad. > > I'm pretty sure there should be a way to sanely reset the interface > before it starts repainting the memory. I agree here. Do you still have an image of that old firmware version, so that we can try to reproduce, and see if we can come up with a way to reset the BM on boot up that would avoid this issue ? Thanks, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com