From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: [PATCH iproute2] ip rule: Require at least one argument for add Date: Tue, 30 Oct 2018 13:59:05 -0700 Message-ID: <20181030205905.14209-1-dsahern@kernel.org> Cc: stephen@networkplumber.org, David Ahern To: netdev@vger.kernel.org Return-path: Received: from mail.kernel.org ([198.145.29.99]:33776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727530AbeJaFyL (ORCPT ); Wed, 31 Oct 2018 01:54:11 -0400 Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern 'ip rule add' with no additional arguments just adds another rule for the main table - which exists by default. Require at least 1 argument similar to delete. Signed-off-by: David Ahern --- ip/iprule.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ip/iprule.c b/ip/iprule.c index d89d808d8909..b465a80785b1 100644 --- a/ip/iprule.c +++ b/ip/iprule.c @@ -691,6 +691,11 @@ static int iprule_modify(int cmd, int argc, char **argv) }; if (cmd == RTM_NEWRULE) { + if (argc == 0) { + fprintf(stderr, + "\"ip rule add\" requires arguments.\n"); + return -1; + } req.n.nlmsg_flags |= NLM_F_CREATE|NLM_F_EXCL; req.frh.action = FR_ACT_TO_TBL; } -- 2.11.0