From: David Miller <davem@davemloft.net>
To: Tristram.Ha@microchip.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, pavel@ucw.cz,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: microchip: initialize mutex before use
Date: Wed, 31 Oct 2018 12:52:54 -0700 (PDT) [thread overview]
Message-ID: <20181031.125254.1993037104948479061.davem@davemloft.net> (raw)
In-Reply-To: <1540943149-26832-1-git-send-email-Tristram.Ha@microchip.com>
From: <Tristram.Ha@microchip.com>
Date: Tue, 30 Oct 2018 16:45:49 -0700
> @@ -1206,6 +1201,12 @@ int ksz_switch_register(struct ksz_device *dev)
> if (dev->pdata)
> dev->chip_id = dev->pdata->chip_id;
>
> + /* mutex is used in next function call. */
> + mutex_init(&dev->reg_mutex);
> + mutex_init(&dev->stats_mutex);
> + mutex_init(&dev->alu_mutex);
> + mutex_init(&dev->vlan_mutex);
> +
Please remove this comment, as per Andrew Lunn's feedback.
prev parent reply other threads:[~2018-11-01 4:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 23:45 [PATCH net] net: dsa: microchip: initialize mutex before use Tristram.Ha
2018-10-31 1:21 ` Andrew Lunn
2018-10-31 7:42 ` Pavel Machek
2018-10-31 19:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031.125254.1993037104948479061.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).