From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl Date: Tue, 30 Oct 2018 20:01:11 -0700 Message-ID: <20181031030111.2s4jsnunjrbfarix@localhost> References: <20181026162742.631-1-mlichvar@redhat.com> <20181026162742.631-2-mlichvar@redhat.com> <20181031022351.24mmvf7u7bcx42rv@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Jacob Keller To: Miroslav Lichvar Return-path: Received: from mail-pl1-f195.google.com ([209.85.214.195]:35251 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbeJaL5T (ORCPT ); Wed, 31 Oct 2018 07:57:19 -0400 Received: by mail-pl1-f195.google.com with SMTP id n4-v6so5959072plp.2 for ; Tue, 30 Oct 2018 20:01:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181031022351.24mmvf7u7bcx42rv@localhost> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Oct 30, 2018 at 07:23:51PM -0700, Richard Cochran wrote: > This collection of automatic variables is getting ugly. May I ask you > to prefix a patch that puts them into reverse Christmas tree before > your changes? (Patch below) Forgot the diff. Here it is... --- diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c index 2012551d93e0..b54b8158ff8a 100644 --- a/drivers/ptp/ptp_chardev.c +++ b/drivers/ptp/ptp_chardev.c @@ -121,18 +121,18 @@ int ptp_open(struct posix_clock *pc, fmode_t fmode) long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg) { - struct ptp_clock_caps caps; - struct ptp_clock_request req; - struct ptp_sys_offset *sysoff = NULL; - struct ptp_sys_offset_precise precise_offset; - struct ptp_pin_desc pd; struct ptp_clock *ptp = container_of(pc, struct ptp_clock, clock); + struct ptp_sys_offset_precise precise_offset; + struct system_device_crosststamp xtstamp; struct ptp_clock_info *ops = ptp->info; + struct ptp_sys_offset *sysoff = NULL; + struct ptp_clock_request req; + struct ptp_clock_caps caps; struct ptp_clock_time *pct; + unsigned int i, pin_index; + struct ptp_pin_desc pd; struct timespec64 ts; - struct system_device_crosststamp xtstamp; int enable, err = 0; - unsigned int i, pin_index; switch (cmd) {