From: Stephen Hemminger <stephen@networkplumber.org>
To: Luca Boccassi <bluca@debian.org>
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH iproute2] Use libbsd for strlcpy if available
Date: Wed, 31 Oct 2018 08:09:22 -0700 [thread overview]
Message-ID: <20181031080922.2ff123eb@xeon-e3> (raw)
In-Reply-To: <20181029104650.24924-1-bluca@debian.org>
On Mon, 29 Oct 2018 10:46:50 +0000
Luca Boccassi <bluca@debian.org> wrote:
> If libc does not provide strlcpy check for libbsd with pkg-config to
> avoid relying on inline version.
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> This allows distro maintainers to be able to choose to reduce
> duplication and let this code be maintained in one place, in the
> external library.
>
I like the idea, but it causes warnings on Debian testing, and maybe other distros.
ipnetns.c:2: warning: "_ATFILE_SOURCE" redefined
#define _ATFILE_SOURCE
In file included from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33,
from /usr/include/string.h:26,
from /usr/include/bsd/string.h:30,
from <command-line>:
/usr/include/features.h:326: note: this is the location of the previous definition
# define _ATFILE_SOURCE 1
Please figure out how to handle this and resubmit. SUSE open build service might
also work to test multiple distro's
next prev parent reply other threads:[~2018-11-01 0:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 10:46 [PATCH iproute2] Use libbsd for strlcpy if available Luca Boccassi
2018-10-29 15:27 ` David Ahern
2018-10-29 15:37 ` Luca Boccassi
2018-10-31 15:09 ` Stephen Hemminger [this message]
2018-10-31 17:54 ` Luca Boccassi
2018-10-31 18:00 ` [PATCH iproute2 v2] " Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031080922.2ff123eb@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bluca@debian.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).