From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute] ss: Actually print left delimiter for columns Date: Wed, 31 Oct 2018 08:31:22 -0700 Message-ID: <20181031083122.24221435@xeon-e3> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "Yoann P." , netdev@vger.kernel.org To: Stefano Brivio Return-path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:41321 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728839AbeKAAaE (ORCPT ); Wed, 31 Oct 2018 20:30:04 -0400 Received: by mail-pl1-f194.google.com with SMTP id p16-v6so1311226plr.8 for ; Wed, 31 Oct 2018 08:31:35 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 29 Oct 2018 23:04:25 +0100 Stefano Brivio wrote: > While rendering columns, we use a local variable to keep track of the > field currently being printed, without touching current_field, which is > used for buffering. > > Use the right pointer to access the left delimiter for the current column, > instead of always printing the left delimiter for the last buffered field, > which is usually an empty string. > > This fixes an issue especially visible on narrow terminals, where some > columns might be displayed without separation. > > Reported-by: YoyPa > Fixes: 691bd854bf4a ("ss: Buffer raw fields first, then render them as a table") > Signed-off-by: Stefano Brivio > Tested-by: YoyPa Looks good, applied.