From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next 0/8] net: sched: pie: align PIE implementation with RFC 8033 Date: Wed, 31 Oct 2018 09:36:34 -0700 Message-ID: <20181031093634.65610ade@xeon-e3> References: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: jhs@mojatatu.com, netdev@vger.kernel.org, tahiliani@nitk.edu.in, dhavaljkhandla26@gmail.com, hrishihiraskar@gmail.com, bmanish15597@gmail.com, sdp.sachin@gmail.com To: Leslie Monis Return-path: Received: from mail-pg1-f195.google.com ([209.85.215.195]:35430 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729341AbeKABf2 (ORCPT ); Wed, 31 Oct 2018 21:35:28 -0400 Received: by mail-pg1-f195.google.com with SMTP id 32-v6so7643969pgu.2 for ; Wed, 31 Oct 2018 09:36:42 -0700 (PDT) In-Reply-To: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 31 Oct 2018 21:49:24 +0530 Leslie Monis wrote: > The current implementation of PIE queueing discipline is according to an IETF > draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper > [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. > However, a lot of necessary modifications and enhancements have been proposed > in RFC 8033, which have not yet been incorporated in the source code of Linux > kernel. The following series of patches helps in achieving the same. > > This patch series includes: > > 1. Change the value of QUEUE_THRESHOLD > 2. Change the default value of pie_params->target > 3. Change the default value of pie_params->tupdate > 4. Change the initial value of pie_vars->burst_time > 5. Add more conditions to auto-tune alpha and beta > 6. Add mechanism to set PIE active/inactive > 7. Add a derandomization mechanism > 8. Update references > > Mohit P. Tahiliani (8): > net: sched: pie: change value of QUEUE_THRESHOLD > net: sched: pie: change default value of pie_params->target > net: sched: pie: change default value of pie_params->tupdate > net: sched: pie: change initial value of pie_vars->burst_time > net: sched: pie: add more conditions to auto-tune alpha and beta > net: sched: pie: add mechanism to set PIE active/inactive > net: sched: pie: add derandomization mechanism > net: sched: pie: update references > > net/sched/sch_pie.c | 77 +++++++++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 63 insertions(+), 14 deletions(-) > Did you do performance tests? Often the RFC is out of date and the actual values are better than those in the standard.