From: Miroslav Lichvar <mlichvar@redhat.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [RFC PATCH 3/4] igb: add support for extended PHC gettime
Date: Wed, 31 Oct 2018 10:39:35 +0100 [thread overview]
Message-ID: <20181031093935.GL31668@localhost> (raw)
In-Reply-To: <20181031022916.nuvbjegnn6bsqxss@localhost>
On Tue, Oct 30, 2018 at 07:29:16PM -0700, Richard Cochran wrote:
> On Fri, Oct 26, 2018 at 06:27:41PM +0200, Miroslav Lichvar wrote:
> > +static int igb_ptp_gettimex(struct ptp_clock_info *ptp,
> > + struct ptp_system_timestamp *sts)
> > +{
> > + struct igb_adapter *igb = container_of(ptp, struct igb_adapter,
> > + ptp_caps);
> > + struct e1000_hw *hw = &igb->hw;
> > + unsigned long flags;
> > + u32 lo, hi;
> > + u64 ns;
> > +
> > + spin_lock_irqsave(&igb->tmreg_lock, flags);
> > +
> > + /* 82576 doesn't have SYSTIMR */
> > + if (igb->hw.mac.type == e1000_82576) {
>
> Instead of if/then/else, can't you follow the pattern of providing
> different function flavors ...
I can. I was just trying to minimize the amount of triplicated code.
In the next version I'll add a patch to deprecate the old gettime
functions, as Jacob suggested, and replace them with the extended
versions, so the amount of code will not change that much.
Thanks,
--
Miroslav Lichvar
next prev parent reply other threads:[~2018-10-31 18:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 16:27 [RFC PATCH 0/4] More accurate PHC<->system clock synchronization Miroslav Lichvar
2018-10-26 16:27 ` [RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl Miroslav Lichvar
2018-10-26 22:16 ` [Intel-wired-lan] " Vinicius Costa Gomes
2018-10-29 12:52 ` Miroslav Lichvar
2018-10-31 2:23 ` Richard Cochran
2018-10-31 3:01 ` Richard Cochran
2018-10-26 16:27 ` [RFC PATCH 2/4] e1000e: add support for extended PHC gettime Miroslav Lichvar
2018-10-26 16:27 ` [RFC PATCH 3/4] igb: " Miroslav Lichvar
2018-10-31 2:29 ` Richard Cochran
2018-10-31 9:39 ` Miroslav Lichvar [this message]
2018-10-31 16:56 ` Keller, Jacob E
2018-10-26 16:27 ` [RFC PATCH 4/4] ixgbe: " Miroslav Lichvar
2018-10-26 16:54 ` Keller, Jacob E
2018-10-29 13:31 ` Miroslav Lichvar
2018-10-29 16:02 ` Keller, Jacob E
2018-10-31 14:40 ` Richard Cochran
2018-10-31 14:49 ` Miroslav Lichvar
2018-10-31 21:16 ` Richard Cochran
2018-10-31 22:08 ` Keller, Jacob E
2018-10-31 16:55 ` Keller, Jacob E
2018-10-26 16:40 ` [RFC PATCH 0/4] More accurate PHC<->system clock synchronization Keller, Jacob E
2018-10-26 16:51 ` Keller, Jacob E
2018-10-31 2:25 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031093935.GL31668@localhost \
--to=mlichvar@redhat.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).