From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next 6/8] net: sched: pie: add mechanism to set PIE
 active/inactive
Date: Wed, 31 Oct 2018 09:41:43 -0700
Message-ID: <20181031094143.3fe008fc@xeon-e3>
References: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com>
        <1541002772-28040-7-git-send-email-lesliemonis@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: jhs@mojatatu.com, netdev@vger.kernel.org, tahiliani@nitk.edu.in,
        dhavaljkhandla26@gmail.com, hrishihiraskar@gmail.com,
        bmanish15597@gmail.com, sdp.sachin@gmail.com
To: Leslie Monis <lesliemonis@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f193.google.com ([209.85.210.193]:39286 "EHLO
        mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729341AbeKABkc (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 31 Oct 2018 21:40:32 -0400
Received: by mail-pf1-f193.google.com with SMTP id c25-v6so7881530pfe.6
        for <netdev@vger.kernel.org>; Wed, 31 Oct 2018 09:41:46 -0700 (PDT)
In-Reply-To: <1541002772-28040-7-git-send-email-lesliemonis@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 31 Oct 2018 21:49:30 +0530
Leslie Monis <lesliemonis@gmail.com> wrote:

> diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
> index c84e91e..b68b367 100644
> --- a/net/sched/sch_pie.c
> +++ b/net/sched/sch_pie.c
> @@ -57,6 +57,7 @@ struct pie_vars {
>  	psched_time_t dq_tstamp;	/* drain rate */
>  	u32 avg_dq_rate;	/* bytes per pschedtime tick,scaled */
>  	u32 qlen_old;		/* in bytes */
> +	bool active;		/* inactive/active */
>  };

Current Linux best practice is to not use bool for true/false values
in a structure. This is because the size of bool is not obvious and
can cause padding.

Recommend using u8 instead.