From: Sasha Levin <sashal@kernel.org>
To: Eduardo Valentin <eduval@amazon.com>
Cc: David Miller <davem@davemloft.net>,
gregkh@linuxfoundation.org, cpaasch@apple.com,
netdev@vger.kernel.org, stable@vger.kernel.org,
stephen@networkplumber.org, luqia@amazon.com,
edumazet@google.com, soheil@google.com, weiwan@google.com,
willemb@google.com
Subject: Re: [PATCH v4.14-stable] sch_netem: restore skb->dev after dequeuing from the rbtree
Date: Wed, 31 Oct 2018 09:44:36 -0400 [thread overview]
Message-ID: <20181031134436.GH194472@sasha-vm> (raw)
In-Reply-To: <20181030191251.GE25819@u40b0340c692b58f6553c.ant.amazon.com>
On Tue, Oct 30, 2018 at 12:12:51PM -0700, Eduardo Valentin wrote:
>Greg,
>
>On Thu, Oct 18, 2018 at 03:43:48PM -0700, David Miller wrote:
>> From: Christoph Paasch <cpaasch@apple.com>
>> Date: Thu, 18 Oct 2018 13:38:40 -0700
>>
>> > Upstream commit bffa72cf7f9d ("net: sk_buff rbnode reorg") got
>> > backported as commit 6b921536f170 ("net: sk_buff rbnode reorg") into the
>> > v4.14.x-tree.
>> >
>> > However, the backport does not include the changes in sch_netem.c
>> >
>> > We need these, as otherwise the skb->dev pointer is not set when
>> > dequeueing from the netem rbtree, resulting in a panic:
>> ...
>> > Fixes: 6b921536f170 ("net: sk_buff rbnode reorg")
>> > Cc: Stephen Hemminger <stephen@networkplumber.org>
>> > Cc: Eric Dumazet <edumazet@google.com>
>> > Cc: Soheil Hassas Yeganeh <soheil@google.com>
>> > Cc: Wei Wang <weiwan@google.com>
>> > Cc: Willem de Bruijn <willemb@google.com>
>> > Signed-off-by: Christoph Paasch <cpaasch@apple.com>
>> > ---
>> >
>> > Notes:
>> > This patch should only make it into v4.14-stable as that's the only branch where
>> > the offending commit has been backported to.
>>
>> Greg, please queue up.
>
>Are you planing to queue this one ?
>
>Looks to me it was a miss on the backport.
>
>It seams that the backport was touching different files, and missed the change
>on net/sched/sch_netem.c. So, to me, even if this patch may not follow the
>strictly the rules of stable, as it is not a patch in upstream, seams to be a
>needed change, even if it is specific to stable linux-4.14.y.
I've queued this patch for 4.14.
prev parent reply other threads:[~2018-10-31 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 20:38 [PATCH v4.14-stable] sch_netem: restore skb->dev after dequeuing from the rbtree Christoph Paasch
2018-10-18 22:43 ` David Miller
2018-10-30 19:12 ` Eduardo Valentin
2018-10-31 13:44 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031134436.GH194472@sasha-vm \
--to=sashal@kernel.org \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eduval@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=luqia@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=stable@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=weiwan@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).