From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime Date: Wed, 31 Oct 2018 14:16:32 -0700 Message-ID: <20181031211632.f7imvzvrsn6pbwgb@localhost> References: <20181026162742.631-1-mlichvar@redhat.com> <20181026162742.631-5-mlichvar@redhat.com> <02874ECE860811409154E81DA85FBB5884CE4B8C@ORSMSX115.amr.corp.intel.com> <20181029133109.GD31668@localhost> <20181031144003.qs235wjmiuwaprps@localhost> <20181031144935.GR31668@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Keller, Jacob E" , "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" To: Miroslav Lichvar Return-path: Received: from mail-pf1-f195.google.com ([209.85.210.195]:45537 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726346AbeKAGQW (ORCPT ); Thu, 1 Nov 2018 02:16:22 -0400 Received: by mail-pf1-f195.google.com with SMTP id v5-v6so3313910pfm.12 for ; Wed, 31 Oct 2018 14:16:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181031144935.GR31668@localhost> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Oct 31, 2018 at 03:49:35PM +0100, Miroslav Lichvar wrote: > > How about separating the PHC timestamp from the ptp_system_timestamp > structure and use NULL to indicate we don't want to read the system > clock? A gettimex64(ptp, ts, NULL) call would be equal to > gettime64(ptp, ts). Doesn't sound too bad to me. Thanks, Richard