From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roman Gushchin <guro@fb.com>
Subject: Re: [PATCH bpf 2/4] bpf: don't set id on after map lookup with
 ptr_to_map_val return
Date: Thu, 1 Nov 2018 01:11:05 +0000
Message-ID: <20181101011057.GA14231@castle.DHCP.thefacebook.com>
References: <20181031230555.3371-1-daniel@iogearbox.net>
 <20181031230555.3371-3-daniel@iogearbox.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "ast@kernel.org" <ast@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:48554 "EHLO
        mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1726174AbeKAKMN (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 1 Nov 2018 06:12:13 -0400
In-Reply-To: <20181031230555.3371-3-daniel@iogearbox.net>
Content-Language: en-US
Content-ID: <CDAFF4ED47D1DC4CBF00DB0ABC304879@namprd15.prod.outlook.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Nov 01, 2018 at 12:05:53AM +0100, Daniel Borkmann wrote:
> In the verifier there is no such semantics where registers with
> PTR_TO_MAP_VALUE type have an id assigned to them. This is only
> used in PTR_TO_MAP_VALUE_OR_NULL and later on nullified once the
> test against NULL has been pattern matched and type transformed
> into PTR_TO_MAP_VALUE.
>=20
> Fixes: 3e6a4b3e0289 ("bpf/verifier: introduce BPF_PTR_TO_MAP_VALUE")
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Roman Gushchin <guro@fb.com>
> Acked-by: Alexei Starovoitov <ast@kernel.org>

Looks good to me.
Acked-by: Roman Gushchin <guro@fb.com>

Thanks!