From: Leon Romanovsky <leon@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mlx5: Fix formats with line continuation whitespace
Date: Thu, 1 Nov 2018 09:20:40 +0200 [thread overview]
Message-ID: <20181101072040.GP3974@mtr-leonro.mtl.com> (raw)
In-Reply-To: <e076161b88d0c87f083f28450a130de8eead618f.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 1765 bytes --]
On Thu, Nov 01, 2018 at 12:09:36AM -0700, Joe Perches wrote:
> The line continuations unintentionally add whitespace so
> instead use coalesced formats to remove the whitespace.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/rl.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/rl.c b/drivers/net/ethernet/mellanox/mlx5/core/rl.c
> index bc86dffdc43c..377b7e65ecf1 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/rl.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/rl.c
> @@ -188,8 +188,7 @@ int mlx5_rl_add_rate(struct mlx5_core_dev *dev, u16 *index,
> /* new rate limit */
> err = mlx5_set_pp_rate_limit_cmd(dev, entry->index, rl);
> if (err) {
> - mlx5_core_err(dev, "Failed configuring rate limit(err %d): \
> - rate %u, max_burst_sz %u, typical_pkt_sz %u\n",
> + mlx5_core_err(dev, "Failed configuring rate limit(err %d): rate %u, max_burst_sz %u, typical_pkt_sz %u\n",
> err, rl->rate, rl->max_burst_sz,
> rl->typical_pkt_sz);
> goto out;
> @@ -218,8 +217,7 @@ void mlx5_rl_remove_rate(struct mlx5_core_dev *dev, struct mlx5_rate_limit *rl)
> mutex_lock(&table->rl_lock);
> entry = find_rl_entry(table, rl);
> if (!entry || !entry->refcount) {
> - mlx5_core_warn(dev, "Rate %u, max_burst_sz %u typical_pkt_sz %u \
> - are not configured\n",
> + mlx5_core_warn(dev, "Rate %u, max_burst_sz %u typical_pkt_sz %u are not configured\n",
double space ^^^^^
> rl->rate, rl->max_burst_sz, rl->typical_pkt_sz);
> goto out;
> }
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2018-11-01 7:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 7:09 [PATCH] mlx5: Fix formats with line continuation whitespace Joe Perches
2018-11-01 7:20 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101072040.GP3974@mtr-leonro.mtl.com \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox