From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Song Liu <songliubraving@fb.com>
Cc: netdev@vger.kernel.org, kernel-team@fb.com, ast@kernel.org,
daniel@iogearbox.net, sandipan@linux.vnet.ibm.com
Subject: Re: [PATCH bpf 0/3] show more accurrate bpf program address
Date: Thu, 1 Nov 2018 16:15:52 -0700 [thread overview]
Message-ID: <20181101231550.5rzlibtccp7hhp2b@ast-mbp> (raw)
In-Reply-To: <20181101070058.2760251-1-songliubraving@fb.com>
On Thu, Nov 01, 2018 at 12:00:55AM -0700, Song Liu wrote:
> This set improves bpf program address showed in /proc/kallsyms and in
> bpf_prog_info. First, real program address is showed instead of page
> address. Second, when there is no subprogram, bpf_prog_info->jited_ksyms
> returns the main prog address.
For the set:
Acked-by: Alexei Starovoitov <ast@kernel.org>
I think we have to make the whole thing consistent like this set does
and send it to stable.
The only other alternative is to invent new cmd and prog_info fields to return
proper jited_ksyms and keep this one buggy forever.
My preference is to fix it.
prev parent reply other threads:[~2018-11-02 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 7:00 [PATCH bpf 0/3] show more accurrate bpf program address Song Liu
2018-11-01 7:00 ` [PATCH bpf 1/3] bpf: show real jited prog address in /proc/kallsyms Song Liu
2018-11-01 7:00 ` [PATCH bpf 2/3] bpf: show real jited address in bpf_prog_info->jited_ksyms Song Liu
2018-11-02 10:09 ` Daniel Borkmann
2018-11-02 10:19 ` Daniel Borkmann
2018-11-02 16:07 ` Song Liu
2018-11-01 7:00 ` [PATCH bpf 3/3] bpf: show main program " Song Liu
2018-11-02 9:57 ` Daniel Borkmann
2018-11-01 23:15 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101231550.5rzlibtccp7hhp2b@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sandipan@linux.vnet.ibm.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox