* [PATCH net] net-sysfs: fix formatting of tx_timeout attribute
@ 2018-11-02 18:33 Julian Wiedmann
2018-11-04 2:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julian Wiedmann @ 2018-11-02 18:33 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Add a missing newline.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
net/core/net-sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index bd67c4d0fcfd..ef06409d768e 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1039,7 +1039,7 @@ static ssize_t tx_timeout_show(struct netdev_queue *queue, char *buf)
trans_timeout = queue->trans_timeout;
spin_unlock_irq(&queue->_xmit_lock);
- return sprintf(buf, "%lu", trans_timeout);
+ return sprintf(buf, "%lu\n", trans_timeout);
}
static unsigned int get_netdev_queue_index(struct netdev_queue *queue)
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net-sysfs: fix formatting of tx_timeout attribute
2018-11-02 18:33 [PATCH net] net-sysfs: fix formatting of tx_timeout attribute Julian Wiedmann
@ 2018-11-04 2:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-11-04 2:31 UTC (permalink / raw)
To: jwi; +Cc: netdev
From: Julian Wiedmann <jwi@linux.ibm.com>
Date: Fri, 2 Nov 2018 19:33:17 +0100
> Add a missing newline.
>
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
> ---
> net/core/net-sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index bd67c4d0fcfd..ef06409d768e 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -1039,7 +1039,7 @@ static ssize_t tx_timeout_show(struct netdev_queue *queue, char *buf)
> trans_timeout = queue->trans_timeout;
> spin_unlock_irq(&queue->_xmit_lock);
>
> - return sprintf(buf, "%lu", trans_timeout);
> + return sprintf(buf, "%lu\n", trans_timeout);
Maybe use 'fmt_ulong' instead?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-04 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-02 18:33 [PATCH net] net-sysfs: fix formatting of tx_timeout attribute Julian Wiedmann
2018-11-04 2:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).