From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net-sysfs: fix formatting of tx_timeout attribute Date: Sat, 03 Nov 2018 19:31:06 -0700 (PDT) Message-ID: <20181103.193106.716765490044215561.davem@davemloft.net> References: <20181102183317.2017-1-jwi@linux.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: jwi@linux.ibm.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:59968 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728873AbeKDLto (ORCPT ); Sun, 4 Nov 2018 06:49:44 -0500 In-Reply-To: <20181102183317.2017-1-jwi@linux.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Julian Wiedmann Date: Fri, 2 Nov 2018 19:33:17 +0100 > Add a missing newline. > > Signed-off-by: Julian Wiedmann > --- > net/core/net-sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c > index bd67c4d0fcfd..ef06409d768e 100644 > --- a/net/core/net-sysfs.c > +++ b/net/core/net-sysfs.c > @@ -1039,7 +1039,7 @@ static ssize_t tx_timeout_show(struct netdev_queue *queue, char *buf) > trans_timeout = queue->trans_timeout; > spin_unlock_irq(&queue->_xmit_lock); > > - return sprintf(buf, "%lu", trans_timeout); > + return sprintf(buf, "%lu\n", trans_timeout); Maybe use 'fmt_ulong' instead?