[PATCH] net: phy: realtek: fix RTL8201F sysfs name

[PATCH] net: phy: realtek: fix RTL8201F sysfs name

[Holger Hoffstätte]

Since 4.19 the following error in sysfs has appeared when using the
r8169 NIC driver:

$cd /sys/module/realtek/drivers
$ls -l
ls: cannot access 'mdio_bus:RTL8201F 10/100Mbps Ethernet': No such file or directory
[..garbled dir entries follow..]

Apparently the forward slash in "10/100Mbps Ethernet" is interpreted
as directory separator that leads nowhere, and was introduced in commit
513588dd44b ("net: phy: realtek: add RTL8201F phy-id and functions").

Fix this by removing the offending slash in the driver name.

Other drivers in net/phy seem to have the same problem, but I cannot
test/verify them.

Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
---
  drivers/net/phy/realtek.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 7fc8508b5231..271e8adc39f1 100644
--- a/drivers/net/phy/realtek.c
+++ b/drivers/net/phy/realtek.c
@@ -220,7 +220,7 @@ static struct phy_driver realtek_drvs[] = {
  		.flags          = PHY_HAS_INTERRUPT,
  	}, {
  		.phy_id		= 0x001cc816,
-		.name		= "RTL8201F 10/100Mbps Ethernet",
+		.name		= "RTL8201F Fast Ethernet",
  		.phy_id_mask	= 0x001fffff,
  		.features	= PHY_BASIC_FEATURES,
  		.flags		= PHY_HAS_INTERRUPT,
-- 
2.19.1

Re: [PATCH] net: phy: realtek: fix RTL8201F sysfs name

[Andrew Lunn]

On Sun, Nov 04, 2018 at 07:02:42PM +0100, Holger Hoffstätte wrote:
> Since 4.19 the following error in sysfs has appeared when using the
> r8169 NIC driver:
> 
> $cd /sys/module/realtek/drivers
> $ls -l
> ls: cannot access 'mdio_bus:RTL8201F 10/100Mbps Ethernet': No such file or directory
> [..garbled dir entries follow..]
> 
> Apparently the forward slash in "10/100Mbps Ethernet" is interpreted
> as directory separator that leads nowhere, and was introduced in commit
> 513588dd44b ("net: phy: realtek: add RTL8201F phy-id and functions").
> 
> Fix this by removing the offending slash in the driver name.
> 
> Other drivers in net/phy seem to have the same problem, but I cannot
> test/verify them.
> 
> Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>

Fixes:513588dd44b ("net: phy: realtek: add RTL8201F phy-id and functions").

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

David, please apply to net.

    Andrew

Re: [PATCH] net: phy: realtek: fix RTL8201F sysfs name

[Florian Fainelli]

On 11/4/2018 10:43 AM, Andrew Lunn wrote:
> On Sun, Nov 04, 2018 at 07:02:42PM +0100, Holger Hoffstätte wrote:
>> Since 4.19 the following error in sysfs has appeared when using the
>> r8169 NIC driver:
>>
>> $cd /sys/module/realtek/drivers
>> $ls -l
>> ls: cannot access 'mdio_bus:RTL8201F 10/100Mbps Ethernet': No such file or directory
>> [..garbled dir entries follow..]
>>
>> Apparently the forward slash in "10/100Mbps Ethernet" is interpreted
>> as directory separator that leads nowhere, and was introduced in commit
>> 513588dd44b ("net: phy: realtek: add RTL8201F phy-id and functions").
>>
>> Fix this by removing the offending slash in the driver name.
>>
>> Other drivers in net/phy seem to have the same problem, but I cannot
>> test/verify them.
>>
>> Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
> 
> Fixes:513588dd44b ("net: phy: realtek: add RTL8201F phy-id and functions").
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> 
> David, please apply to net.

We should probably seek a more generic solution within sysfs to deny
specific problematic characters from being used, such as ., .., / etc.
-- 
Florian

Re: [PATCH] net: phy: realtek: fix RTL8201F sysfs name

[Andrew Lunn]

On Sun, Nov 04, 2018 at 07:02:42PM +0100, Holger Hoffstätte wrote:
> Since 4.19 the following error in sysfs has appeared when using the
> r8169 NIC driver:
> 
> $cd /sys/module/realtek/drivers
> $ls -l
> ls: cannot access 'mdio_bus:RTL8201F 10/100Mbps Ethernet': No such file or directory
> [..garbled dir entries follow..]
> 
> Apparently the forward slash in "10/100Mbps Ethernet" is interpreted
> as directory separator that leads nowhere, and was introduced in commit
> 513588dd44b ("net: phy: realtek: add RTL8201F phy-id and functions").
> 
> Fix this by removing the offending slash in the driver name.
> 
> Other drivers in net/phy seem to have the same problem, but I cannot
> test/verify them.

Hi Holger

This last comment would generally be placed after the ---. It will
then not appear in the commit message.

Also, in future, please put the target tree, net or net-next as part
of the subject line:

[PATCH net] ....

Thanks
	Andrew

Re: [PATCH] net: phy: realtek: fix RTL8201F sysfs name

[David Miller]

From: Andrew Lunn <andrew@lunn.ch>
Date: Sun, 4 Nov 2018 19:47:41 +0100

> On Sun, Nov 04, 2018 at 07:02:42PM +0100, Holger Hoffstätte wrote:
>> Since 4.19 the following error in sysfs has appeared when using the
>> r8169 NIC driver:
>> 
>> $cd /sys/module/realtek/drivers
>> $ls -l
>> ls: cannot access 'mdio_bus:RTL8201F 10/100Mbps Ethernet': No such file or directory
>> [..garbled dir entries follow..]
>> 
>> Apparently the forward slash in "10/100Mbps Ethernet" is interpreted
>> as directory separator that leads nowhere, and was introduced in commit
>> 513588dd44b ("net: phy: realtek: add RTL8201F phy-id and functions").
>> 
>> Fix this by removing the offending slash in the driver name.
>> 
>> Other drivers in net/phy seem to have the same problem, but I cannot
>> test/verify them.
> 
> Hi Holger
> 
> This last comment would generally be placed after the ---. It will
> then not appear in the commit message.
> 
> Also, in future, please put the target tree, net or net-next as part
> of the subject line:
> 
> [PATCH net] ....

This didn't apply cleanly, something mangled the patch.

But I fixed it up and queued this up for -stable.