From: David Miller <davem@davemloft.net>
To: saeedm@mellanox.com
Cc: jgg@mellanox.com, netdev@vger.kernel.org, eric.dumazet@gmail.com,
eranbe@mellanox.com, leonro@mellanox.com, arnd@arndb.de,
akpm@linux-foundation.org
Subject: Re: [RFC PATCH] net/mlx5e: Temp software stats variable is not required
Date: Mon, 05 Nov 2018 11:27:35 -0800 (PST) [thread overview]
Message-ID: <20181105.112735.2095940458004008995.davem@davemloft.net> (raw)
In-Reply-To: <002da677314734dedd31be1e1b199dd4f1ae8457.camel@mellanox.com>
From: Saeed Mahameed <saeedm@mellanox.com>
Date: Mon, 5 Nov 2018 19:13:59 +0000
> On Sat, 2018-11-03 at 19:36 -0700, David Miller wrote:
>> From: Saeed Mahameed <saeedm@mellanox.com>
>> Date: Fri, 2 Nov 2018 18:54:22 -0700
>>
>> > +static void mlx5e_fold_sw_stats(struct mlx5e_priv *priv, struct
>> > rtnl_link_stats64 *s)
>> > +{
>> > + int i;
>> > +
>> > + /* not required ? */
>> > + memset(s, 0, sizeof(*s));
>>
>> Why wouldn't this be required?
>>
>
> I just checked it is already done by the stack @dev_get_stats()
Then please document this in the commit message or similar.
prev parent reply other threads:[~2018-11-06 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-03 1:54 [RFC PATCH] net/mlx5e: Temp software stats variable is not required Saeed Mahameed
2018-11-04 2:36 ` David Miller
2018-11-05 19:13 ` Saeed Mahameed
2018-11-05 19:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105.112735.2095940458004008995.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=eranbe@mellanox.com \
--cc=eric.dumazet@gmail.com \
--cc=jgg@mellanox.com \
--cc=leonro@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).