From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [RFC PATCH] net/mlx5e: Temp software stats variable is not
 required
Date: Mon, 05 Nov 2018 11:27:35 -0800 (PST)
Message-ID: <20181105.112735.2095940458004008995.davem@davemloft.net>
References: <20181103015422.22978-1-saeedm@mellanox.com>
        <20181103.193617.810293775666516890.davem@davemloft.net>
        <002da677314734dedd31be1e1b199dd4f1ae8457.camel@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: jgg@mellanox.com, netdev@vger.kernel.org, eric.dumazet@gmail.com,
        eranbe@mellanox.com, leonro@mellanox.com, arnd@arndb.de,
        akpm@linux-foundation.org
To: saeedm@mellanox.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:60524 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2387520AbeKFEss (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 5 Nov 2018 23:48:48 -0500
In-Reply-To: <002da677314734dedd31be1e1b199dd4f1ae8457.camel@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Saeed Mahameed <saeedm@mellanox.com>
Date: Mon, 5 Nov 2018 19:13:59 +0000

> On Sat, 2018-11-03 at 19:36 -0700, David Miller wrote:
>> From: Saeed Mahameed <saeedm@mellanox.com>
>> Date: Fri,  2 Nov 2018 18:54:22 -0700
>> 
>> > +static void mlx5e_fold_sw_stats(struct mlx5e_priv *priv, struct
>> > rtnl_link_stats64 *s)
>> > +{
>> > +	int i;
>> > +
>> > +	/* not required ? */
>> > +	memset(s, 0, sizeof(*s));
>> 
>> Why wouldn't this be required?
>> 
> 
> I just checked it is already done by the stack @dev_get_stats()

Then please document this in the commit message or similar.