From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] Include bsd/string.h only in include/utils.h Date: Mon, 5 Nov 2018 08:39:44 -0800 Message-ID: <20181105083944.495bd03c@xeon-e3> References: <20181101222527.29439-1-bluca@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dsahern@gmail.com To: Luca Boccassi Return-path: Received: from mail-pf1-f195.google.com ([209.85.210.195]:45507 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387420AbeKFCAY (ORCPT ); Mon, 5 Nov 2018 21:00:24 -0500 Received: by mail-pf1-f195.google.com with SMTP id p17-v6so4308189pfj.12 for ; Mon, 05 Nov 2018 08:39:53 -0800 (PST) In-Reply-To: <20181101222527.29439-1-bluca@debian.org> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 1 Nov 2018 22:25:27 +0000 Luca Boccassi wrote: > This is simpler and cleaner, and avoids having to include the header > from every file where the functions are used. The prototypes of the > internal implementation are in this header, so utils.h will have to be > included anyway for those. > > Fixes: 508f3c231efb ("Use libbsd for strlcpy if available") > > Signed-off-by: Luca Boccassi Looks better. Applied