From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH] sock_diag: fix autoloading of the raw_diag module
Date: Mon, 5 Nov 2018 21:22:45 +0300
Message-ID: <20181105182245.GD2869@uranus.lan>
References: <20181105063715.21639-1-avagin@gmail.com>
 <20181105071234.GC2869@uranus.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        Xin Long <lucien.xin@gmail.com>
To: Andrei Vagin <avagin@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-lf1-f68.google.com ([209.85.167.68]:36321 "EHLO
        mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725844AbeKFDno (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 5 Nov 2018 22:43:44 -0500
Received: by mail-lf1-f68.google.com with SMTP id h192so6886511lfg.3
        for <netdev@vger.kernel.org>; Mon, 05 Nov 2018 10:22:48 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20181105071234.GC2869@uranus.lan>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Nov 05, 2018 at 10:12:34AM +0300, Cyrill Gorcunov wrote:
> 
> Andrew, looking into kernel code I wonder, maybe we should simply
> add this protocol into inet_protos during net/ipv4/af_inet.c:inet_init?
> It will require to add netns_ok into raw_prot of course.

After spending some time on this idea I think your patch is better,
since it is small and suitable for a -stable fix (because the former
issue is definitely changing the kernel behaviour, the fix should
be passed to -stable as well).

Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>