From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael =?UTF-8?B?QsO8c2No?= Subject: Re: [PATCH v2 3/3] b43: Use cordic algorithm from kernel library Date: Mon, 5 Nov 2018 22:39:09 +0100 Message-ID: <20181105223909.61860cdd@wiggum> References: <77709642dacd9d855618bd9c2f3a56a88e881eaa.1541446422.git-series.plaes@plaes.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/=TxR.mRkCm2uX+V6VXlLC0t"; protocol="application/pgp-signature" Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, "David S. Miller" , Kalle Valo , b43-dev@lists.infradead.org To: Priit Laes Return-path: In-Reply-To: <77709642dacd9d855618bd9c2f3a56a88e881eaa.1541446422.git-series.plaes@plaes.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --Sig_/=TxR.mRkCm2uX+V6VXlLC0t Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 5 Nov 2018 21:37:18 +0200 Priit Laes wrote: > Kernel library has a common cordic algorithm which is identical > to internally implementatd one, so use it and drop the duplicate > implementation. >=20 > Signed-off-by: Priit Laes This looks nice. But what is the testing status of this? Has this been tested on actual b43-LP hardware? Is the replacement algorithm exactly the same, or are there slight differences (e.g. in corner cases)? --=20 Michael --Sig_/=TxR.mRkCm2uX+V6VXlLC0t Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEihRzkKVZOnT2ipsS9TK+HZCNiw4FAlvguH0ACgkQ9TK+HZCN iw4TGxAA3rEjXSOKh/BC/zHNPYbmSGUHFPEwXSowS/EDt+0F2YwEpWEXzVGQOgiT qBxKLLcy5TyJ430lv1D9u6f0lVVyUz1sPTquT5NmIiktE7UAc4RP8w6ACbtI9OZ2 4zqsF2G15mkzE8oilxC+EI/TlLKsli4pKTWgpL+UoShSRnG9cmFbUcbi/kzW0RbC 7ciXgbqv/eirZcTREniI6e0/Qllst5NTlLLyBgXTCCg5hwLgBzO28DiJZR3ynGUD xPyyZ1NV+IfiueTCgF8DyFka1OA1uvAMsrVh8JDG1DXDlAaaS+bC8R/OUWymovcv 5+f1SbzN/ANFLzTaNzd0vle9Te4V+OY/UcytZlg1Ijlud5YRsDm5ThnzM7MVDPTa 3gfddvjte9PS+SDP4K3KcFUpnK6eZ0GuHJ1w6TEit3LAmjTxyuTV5x3iBUc0cnC3 robcDI+XKUFKj5V0Ze5GOcuZ/L1kvMTSf6GR4QWrHC2k08WTNttvgcn2zAa1qPX5 zZK0DdnMkBfUrM1PJqTrfMb6O1N+/xMlupwyGJs90pzaWdn51vrBFzjy+0O7jwTc cte2lVIec/Oy6oN5ohjkm5aPv4DGjf2q+UVfANjpldvWpG/GfQ5yG4Ip26f7XcKT ucrVAJlhgNl7jFjxdrKiqaBMEsr1Wk3jUthIJFdbwaciTBJDNGc= =Q3Le -----END PGP SIGNATURE----- --Sig_/=TxR.mRkCm2uX+V6VXlLC0t--