From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 01/11] udp: Handle ICMP errors for tunnels
 with same destination port on both endpoints
Date: Tue, 06 Nov 2018 15:25:01 -0800 (PST)
Message-ID: <20181106.152501.1178657449422714101.davem@davemloft.net>
References: <cover.1541533786.git.sbrivio@redhat.com>
        <9f1e659e3745bbc8f29a9debb9bb8c0d8918fa24.1541533786.git.sbrivio@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: sd@queasysnail.net, lucien.xin@gmail.com, netdev@vger.kernel.org
To: sbrivio@redhat.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:55238 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727749AbeKGIwk (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 7 Nov 2018 03:52:40 -0500
In-Reply-To: <9f1e659e3745bbc8f29a9debb9bb8c0d8918fa24.1541533786.git.sbrivio@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Stefano Brivio <sbrivio@redhat.com>
Date: Tue,  6 Nov 2018 22:38:57 +0100

> +	/* Network header needs to point to the outer IPv4 header inside ICMP */
> +	skb_reset_network_header(skb);
> +	iph = ip_hdr(skb);
> +	/* Transport header needs to point to the UDP header */
> +	skb_set_transport_header(skb, iph->ihl << 2);

Please put an empty line before the second comment.