Re: [PATCH net-next 09/11] udp: Support for error handlers of tunnels with arbitrary destination port

[David Miller <davem@davemloft.net>]

From: Stefano Brivio <sbrivio@redhat.com>
Date: Tue,  6 Nov 2018 22:39:05 +0100

> diff --git a/include/net/ip6_tunnel.h b/include/net/ip6_tunnel.h
> index 236e40ba06bf..7855966b4a19 100644
> --- a/include/net/ip6_tunnel.h
> +++ b/include/net/ip6_tunnel.h
> @@ -69,6 +69,8 @@ struct ip6_tnl_encap_ops {
>  	size_t (*encap_hlen)(struct ip_tunnel_encap *e);
>  	int (*build_header)(struct sk_buff *skb, struct ip_tunnel_encap *e,
>  			    u8 *protocol, struct flowi6 *fl6);
> +	int (*err_handler)(struct sk_buff *, struct inet6_skb_parm *opt,
> +			   u8 type, u8 code, int offset, __be32 info);
>  };

Please give names to all of the arguments in this new method.

...
> diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h
> index b0d022ff6ea1..5980659312e5 100644
> --- a/include/net/ip_tunnels.h
> +++ b/include/net/ip_tunnels.h
> @@ -311,6 +311,7 @@ struct ip_tunnel_encap_ops {
>  	size_t (*encap_hlen)(struct ip_tunnel_encap *e);
>  	int (*build_header)(struct sk_buff *skb, struct ip_tunnel_encap *e,
>  			    u8 *protocol, struct flowi4 *fl4);
> +	int (*err_handler)(struct sk_buff *, u32);

Likewise.