From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] wlcore: Fix the return value in case of error in 'wlcore_vendor_cmd_smart_config_start()' Date: Tue, 6 Nov 2018 16:53:32 +0000 (UTC) Message-ID: <20181106165332.9446F60BDE@smtp.codeaurora.org> References: <20181016073940.26797-1-christophe.jaillet@wanadoo.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, tony@atomide.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET To: Christophe JAILLET Return-path: In-Reply-To: <20181016073940.26797-1-christophe.jaillet@wanadoo.fr> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Christophe JAILLET wrote: > We return 0 unconditionally at the end of > 'wlcore_vendor_cmd_smart_config_start()'. > However, 'ret' is set to some error codes in several error handling paths > and we already return some error codes at the beginning of the function. > > Return 'ret' instead to propagate the error code. > > Fixes: 80ff8063e87c ("wlcore: handle smart config vendor commands") > Signed-off-by: Christophe JAILLET Patch applied to wireless-drivers-next.git, thanks. 3419348a97bc wlcore: Fix the return value in case of error in 'wlcore_vendor_cmd_smart_config_start()' -- https://patchwork.kernel.org/patch/10643195/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches