From: Ido Schimmel <idosch@idosch.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Ido Schimmel <idosch@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Jiri Pirko <jiri@mellanox.com>,
Shalom Toledo <shalomt@mellanox.com>,
Moshe Shemesh <moshe@mellanox.com>,
"dsahern@gmail.com" <dsahern@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
mlxsw <mlxsw@mellanox.com>
Subject: Re: [PATCH net-next 1/3] devlink: Add fw_version_check generic parameter
Date: Tue, 6 Nov 2018 22:37:51 +0200 [thread overview]
Message-ID: <20181106203751.GA30851@splinter.mtl.com> (raw)
In-Reply-To: <20181106121913.036b8c4d@cakuba.netronome.com>
On Tue, Nov 06, 2018 at 12:19:13PM -0800, Jakub Kicinski wrote:
> On Tue, 6 Nov 2018 20:05:00 +0000, Ido Schimmel wrote:
> > From: Shalom Toledo <shalomt@mellanox.com>
> >
> > Many drivers checking the device's firmware version during the
> > initialization flow and flashing a compatible version if the current
> > version is not.
> >
> > fw_version_check gives the ability to skip this check which allows to run
> > the device with a different firmware version than required by the driver
> > for testing and/or debugging purposes.
> >
> > Signed-off-by: Shalom Toledo <shalomt@mellanox.com>
> > Reviewed-by: Jiri Pirko <jiri@mellanox.com>
> > Signed-off-by: Ido Schimmel <idosch@mellanox.com>
>
> The documentation is missing, so it's hard to comment on the definition
> of the parameter...
I assume you mean Documentation/networking/devlink-params.txt ?
> We have a FW loading policy for NFP, too, so it'd be good to see if we
> can find a common ground.
If the parameter is set, then device runs with whatever firmware version
was last flashed (via ethtool, for example). Otherwise, the driver will
flash a version according to its policy. In mlxsw, it is a specific
version.
Will that work for you?
next prev parent reply other threads:[~2018-11-07 6:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 20:04 [PATCH net-next 0/3] mlxsw: Add fw_version_check devlink parameter Ido Schimmel
2018-11-06 20:05 ` [PATCH net-next 1/3] devlink: Add fw_version_check generic parameter Ido Schimmel
2018-11-06 20:19 ` Jakub Kicinski
2018-11-06 20:37 ` Ido Schimmel [this message]
2018-11-06 22:47 ` Jakub Kicinski
2018-11-07 10:11 ` Ido Schimmel
2018-11-07 19:05 ` Jakub Kicinski
2018-11-08 16:22 ` Ido Schimmel
2018-11-06 20:05 ` [PATCH net-next 2/3] mlxsw: core: Reset firmware after flash during driver initialization Ido Schimmel
2018-11-06 20:05 ` [PATCH net-next 3/3] mlxsw: spectrum: Skip firmware version check based on devlink parameter Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106203751.GA30851@splinter.mtl.com \
--to=idosch@idosch.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=shalomt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).