From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma] net/mlx5: Fix XRC SRQ umem valid bits Date: Tue, 6 Nov 2018 22:02:13 +0000 Message-ID: <20181106220206.GC30490@mellanox.com> References: <20181031102028.9142-1-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Leon Romanovsky , Yishai Hadas , RDMA mailing list , Artemy Kovalyov , Saeed Mahameed , linux-netdev , Leon Romanovsky To: Doug Ledford Return-path: Received: from mail-eopbgr20068.outbound.protection.outlook.com ([40.107.2.68]:6970 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725951AbeKGH3i (ORCPT ); Wed, 7 Nov 2018 02:29:38 -0500 In-Reply-To: Content-Language: en-US Content-ID: <7FFD0158A0333846ADDBC1F908141342@eurprd05.prod.outlook.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Nov 06, 2018 at 04:31:08PM -0500, Doug Ledford wrote: > On Wed, 2018-10-31 at 12:20 +0200, Leon Romanovsky wrote: > > From: Yishai Hadas > >=20 > > Adapt XRC SRQ to the latest HW specification with fixed definition > > around umem valid bits. The previous definition relied on a bit which > > was taken for other purposes in legacy FW. > >=20 > > Fixes: bd37197554eb ("net/mlx5: Update mlx5_ifc with DEVX UID bits") > > Signed-off-by: Yishai Hadas > > Reviewed-by: Artemy Kovalyov > > Signed-off-by: Leon Romanovsky > > Hi Doug, Jason > >=20 > > This commit fixes code sent in this merge window, so I'm not marking it > > with any rdma-rc/rdma-next. It will be better to be sent during this me= rge > > window if you have extra pull request to issue, or as a -rc material, i= f > > not. > >=20 > > BTW, we didn't combine reserved fields, because our convention is to al= ign such > > fields to 32 bits for better readability. > >=20 > > Thanks >=20 > This looks fine. Let me know when it's in the mlx5-next tree to pull. It needs to go to -rc...=20 This needs a mlx5-rc branch for this I guess? Jason=20